gcrhelper: add automatic GCR/Artifact Registry auth on GCE#82
Open
jossy wants to merge 1 commit intocloudfoundry:mainfrom
Open
gcrhelper: add automatic GCR/Artifact Registry auth on GCE#82jossy wants to merge 1 commit intocloudfoundry:mainfrom
jossy wants to merge 1 commit intocloudfoundry:mainfrom
Conversation
3 tasks
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of cloudfoundry/diego-release#1124. See that PR for full details.
Adds GCR credential lookup to
convertCredentials()inconversion_helpers.go: if no credentials are stored for a docker image and the URL matches a GCR/Artifact Registry host, the GCE instance metadata server is queried for an OAuth2 token. Falls back silently on non-GCE environments.Backward Compatibility
Breaking Change? No
The new code only runs when no credentials are stored for the image. All existing behaviour is preserved.